promote committers #1492
Merged
promote committers #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalvin
requested review from
cwen0,
zhouqiang-cl and
a team
and removed request for
cwen0
Signed-off-by: dcalvin <wenghao@pingcap.com>
dcalvin
force-pushed
the
promote-committer
branch
from
d0caefe
to
80ee94e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
- Coverage 55.78% 52.02% -3.76%
==========================================
Files 68 80 +12
Lines 4383 5109 +726
==========================================
+ Hits 2445 2658 +213
- Misses 1768 2181 +413
- Partials 170 270 +100
Continue to review full report at Codecov.
|
zhouqiang-cl
reviewed
Feb 5, 2021
|
@Andrewmatilde Could you please comment and leave your org and email? |
OK,I leave it in my profile page. |
Gallardot
reviewed
Feb 18, 2021
Gallardot
reviewed
Feb 18, 2021
Signed-off-by: dcalvin <wenghao@pingcap.com>
dcalvin
force-pushed
the
promote-committer
branch
from
cd9c815
to
fcc62cc
Compare
Signed-off-by: dcalvin <wenghao@pingcap.com>
|
@Gallardot @cwen0 PTAL again. |
Gallardot
requested changes
Feb 19, 2021
MAINTAINERS.md
Outdated
| | Yihao Fu ([fewdan](https://github.com/fewdan)) | [fuyihao@pingcap.com](fuyihao@pingcap.com) | [PingCAP](https://www.pingcap.com/) | | ||
| | Jiaxing Wu ([Colstuwjx](https://github.com/Colstuwjx) ) | [wjx_colstu@hotmail.com](wjx_colstu@hotmail.com) | [Kingnet](www.kingnet.com/) | | ||
| | Shuyang Wu ([Yiyiyimu](https://github.com/Yiyiyimu) ) | [wosoyoung@gmail.com]( wosoyoung@gmail.com) | [APISIX](https://apisix.apache.org/) | | ||
| | Shenan Zhang ([Andrewmatilde](https://github.com/Andrewmatilde) | [zhangshenan@pingcap.com](zhangshenan@pingcap.com) | [PingCAP](https://www.pingcap.com/) | |
There was a problem hiding this comment.
Suggested change
| | Shenan Zhang ([Andrewmatilde](https://github.com/Andrewmatilde) | [zhangshenan@pingcap.com](zhangshenan@pingcap.com) | [PingCAP](https://www.pingcap.com/) | | |
| | Shenan Zhang ([Andrewmatilde](https://github.com/Andrewmatilde)) | [zhangshenan@pingcap.com](mailto:zhangshenan@pingcap.com) | [PingCAP](https://www.pingcap.com/) | |
MAINTAINERS.md
Outdated
| | Shuyang Wu ([Yiyiyimu](https://github.com/Yiyiyimu) ) | [wosoyoung@gmail.com]( wosoyoung@gmail.com) | [APISIX](https://apisix.apache.org/) | | ||
| | Shenan Zhang ([Andrewmatilde](https://github.com/Andrewmatilde) | [zhangshenan@pingcap.com](zhangshenan@pingcap.com) | [PingCAP](https://www.pingcap.com/) | | ||
| | Xiang Wang ([WangXiangUSTC](https://github.com/WangXiangUSTC)) | [wangxiang@pingcap.com](wangxiang@pingcap.com) | [PingCAP](https://www.pingcap.com/) | | ||
| | Wenbo Zhang ([ethercflow](https://github.com/ethercflow) ) | [zhangwenbo@pingcap.com](zhangwenbo@pingcap.com) | [PingCAP](https://www.pingcap.com/) | |
There was a problem hiding this comment.
Suggested change
| | Wenbo Zhang ([ethercflow](https://github.com/ethercflow) ) | [zhangwenbo@pingcap.com](zhangwenbo@pingcap.com) | [PingCAP](https://www.pingcap.com/) | | |
| | Wenbo Zhang ([ethercflow](https://github.com/ethercflow)) | [zhangwenbo@pingcap.com](mailto:zhangwenbo@pingcap.com) | [PingCAP](https://www.pingcap.com/) | |
MAINTAINERS.md
Outdated
| | Name | Email | Org | | ||
| |------------------------------|--------------------------|---------| | ||
| | Glen Yang ([[G1eny0ung](https://github.com/g1eny0ung)) | [yangyue@pingcap.com](yangyue@pingcap.com) | [PingCAP](https://www.pingcap.com/) | | ||
| | Yihao Fu ([fewdan](https://github.com/fewdan)) | [fuyihao@pingcap.com](fuyihao@pingcap.com) | [PingCAP](https://www.pingcap.com/) | |
There was a problem hiding this comment.
Suggested change
| | Yihao Fu ([fewdan](https://github.com/fewdan)) | [fuyihao@pingcap.com](fuyihao@pingcap.com) | [PingCAP](https://www.pingcap.com/) | | |
| | Yihao Fu ([fewdan](https://github.com/fewdan)) | [fuyihao@pingcap.com](mailto:fuyihao@pingcap.com) | [PingCAP](https://www.pingcap.com/) | |
There was a problem hiding this comment.
I think the rest also should be appended mailto:
Signed-off-by: dcalvin <wenghao@pingcap.com>
fewdan
requested changes
Feb 19, 2021
Signed-off-by: dcalvin <wenghao@pingcap.com>
|
@fewdan @Gallardot PTAL again. Thanks for being so perceptive. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with our Governance, I am pleased to promote the following Committers for Chaos Mesh. I would like to hereby thank them for their great contributions to the project and look forward to seeing more of their growth and engagements.
g1eny0ung (Glen Yang)
What does becoming a Chaos Mesh Committer mean to you?
Thanks to all of my people who work with me at Chaos Mesh, and I'm glad to be a committer. For me, being a committer allows me to be deeply involved in the open-source itself and what I do can help anyone in need. It makes me feel that I am doing something meaningful. I will continue to focus on the ease of use of Chaos Mesh in the future, and strive to make it better.
Contribution Highlights
I mainly developed Chaos Dashboard in Chaos Mesh, The following are some of the highlights:
My first commit: #445.
Continuous improvement of the dashboard: #577, #593, #628, #898, #1029, #1285.
What I am working on: #1283. This is a To-Do list, which covers the changes that have been completed or need to be made to the dashboard in the future.
Design and maintain the official website of Chaos Mesh: https://chaos-mesh.org/
Andrewmatilde (Shenan Zhang)
What does becoming a Chaos Mesh Committer mean to you?
It means my contribution to the chaos-mesh has been recognized.
Contribution Highlights
Works in HTTP-Chaos, specifically, I helped add the CRD and API of HTTP-Chaos. #871
ethercflow (Wenbo Zhang)
What does becoming a Chaos Mesh Committer mean to you?
I feel honored and lucky to be involved in such an interesting and meaningful project early on.
Please list the highlights of your work (e.g. notable PRs, involvement in the community, etc.) at Chaos Mesh, preferably with reference links.
Support kernel chaos (#273), in which I contributed to adding kernel chaos, a new chaos type, to Chaos Mesh.
WangXiangUSTC (Xiang Wang)
What does becoming a Chaos Mesh Committer mean to you?
It means I have a deeper understanding of Chaos Mesh and Chaos Engineering, For example, how to develop a new Chaos feature and which point should we focus on.
And I can contribute more to the project, not only the development but also the community. I will promote the project and help new contributors get involved in the project.
Contribution Highlights
Implement Chaos Mesh Action: https://github.com/chaos-mesh/chaos-mesh-action
Implement DNSChaos: #1039
dashboard: support token: #1188
speed up the e2e test: #1279
make e2e test more stable: #1355
fewdan (Yihao Fu)
What does becoming a Chaos Mesh Committer mean to you?
It is an honor for me to become a Chaos Mesh Committer, which means that the community recognizes me. I will do my best to make more contributions to make Chaos Mesh better and better. It is a meaningful thing to be able to do a project better with the community.
Contribution Highlights
My main work is related to Chaos Mesh Dashboard, such as various APIs on the back end. At the same time, there are some specific chaos that I contributed to, such as container-kill and AwsChaos. Specifically, container-kill chaos expands PodChaos, allowing users to kill specific containers with more fine-grained chaos (PR #203). And AwsChaos helps users inject chaos into some components of AWS, such as EC2-stop and EC2-restart (PR #1330).
STRRL (Zhiqiang Zhou)
What does becoming a Chaos Mesh Committer mean to you?
I'm very pleased to be the committer of Chaos Mesh. It means my contribution on Chaos Mesh wins the approval of maintainers.
Contribution Highlights
supporting namespace scoped chaos [add] Support namespace scoped chaos #872
chaos mesh workflow(WIP) Workflow: docs, interfaces and serial scheduler #1418
Yiyiyimu (Shuyang Wu)
What does becoming a Chaos Mesh Committer mean to you?
It's such an honor to become a Chaos Mesh committer and I'm so glad that my work could help people. I'll try to contribute more to the community and look forward to it becoming better!!
Contribution Highlights
develop a debug tool
chaosctl debugto help collect debug information (feat: chaosctl for print debug info #1074)fix(ed&ing) several two-phase controller related issues (feature: pause for certain duration #1016, Bugfix: Use
Lastto get current phase at start time of standard cron #1286, [WIP] fix: useeventfilterto inform reconciler if spec got updated #1341)Colstuwjx (Jiaxing Wu)
What does becoming a Chaos Mesh Committer mean to you?
I'm also one of the users of chaos mesh. After being a Chaos Mesh Committer, I will get more actively involved in the community, and I could give more feedback both from user and developer sight. It's also a good chance to learn the operation of the community, how to make an elegant design of a complex system, and the most important thing, to work together with the community developers!
Contribution Highlights
I've been contributed to Chaos Mesh by the following PRs:
One of the missing features for the chaos spec is the expression selector support, and I did it, see PR feat: make selector support expression selectors. #1277;
The Chaos Mesh package structure was not pretty good, and it causes some cycle-reference issues, see issue 1072#comment, and I've contributed to removing some cross package references within PR chore: remove common.ControllerCfg reference from utils pkg #1175;
I also contributed some fix PRs, for example, I fixed a bug in the two-phase controller after the PR merged, it makes the retry operation more robust, see PR fix: pod deletion caused twophase phase=Failed chaos. #946. I also tweaked the logging level while the controller catches a known bug after the PR merged, chaos controller wouldn't print lots of panic log due to the known issues, see PR fix: make restart watcher log level down to info. #914;
the other doc and chore PRs.
Besides the contribution of PRs, I also get involved in the review process. For example, I reviewed one of the new coming 2.0 features of Chaos Mesh, the Chaos Workflow, and I give some suggestions from design level and code level, see PR 1418 #comment and rfc PR #10. I also helped review PR #1221 and gave some useful comments.