Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create .nvmrc #1875

Closed
wants to merge 3 commits into from
Closed

feat: create .nvmrc #1875

wants to merge 3 commits into from

Conversation

seve
Copy link
Member

@seve seve commented Jan 24, 2022

Reviewers

Functional: @tihuan

Readability: @danieljhegeman


Changes

  • add
    • .nvmrc to set a standard version of node for nvm to use
  • modify
    • bump next.js to bump node-sass to allow node v16

Notes:

Node v16 was needed for m1 support

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks for adding and fixing this! LGTM 🤩 👏

@seve seve changed the title feat: create .node_version feat: create .nvmrc Jan 24, 2022
@seve seve linked an issue Jan 24, 2022 that may be closed by this pull request
@seve
Copy link
Member Author

seve commented Jan 24, 2022

@tihuan I might have missed something, but I don't think this minor bump allows us to close any issues, correct? Is the DoD for #1705 to update next to latest, or did we just want to get rid of the vuln?

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #1875 (f0b2ce3) into main (ae9b624) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1875   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         105      105           
  Lines        6925     6925           
=======================================
  Hits         6562     6562           
  Misses        363      363           
Flag Coverage Δ
backend 94.75% <ø> (ø)
python 94.75% <ø> (ø)
unitTest 94.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae9b624...f0b2ce3. Read the comment docs.

@tihuan
Copy link
Contributor

tihuan commented Jan 24, 2022

DoD of #1705 is just upgrading the patch version and upgrade node-sass to the latest, which should get rid of the vuln!

So this PR should close #1705 🙆‍♂️

Thanks, @seve !

@seve seve linked an issue Jan 24, 2022 that may be closed by this pull request
@seve seve enabled auto-merge (squash) January 24, 2022 23:49
@seve
Copy link
Member Author

seve commented Jan 25, 2022

Looks like this patch didn't solve our needs, ongoing thread over here

@seve seve marked this pull request as draft January 31, 2022 20:54
auto-merge was automatically disabled January 31, 2022 20:54

Pull request was converted to draft

@seve seve closed this Feb 10, 2022
@metakuni metakuni deleted the seve/node-version branch May 18, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add node engine specification / standardize node version Upgrade next and node-sass to the latest version
2 participants