Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node engine specification / standardize node version #1738

Closed
danieljhegeman opened this issue Dec 8, 2021 · 3 comments
Closed

Add node engine specification / standardize node version #1738

danieljhegeman opened this issue Dec 8, 2021 · 3 comments
Assignees
@seve
Labels
frontend Frontend work P3 Priority 3 - Do we need P3? tech Tech issues that do not require product prioritization. Tech debt, tooling, ops, etc.

Comments

@danieljhegeman
Copy link
Contributor

The Data Portal (and likely Explorer) does not specify the requisite node version / node engine in package.json. The developer has to figure out which node version range works; if I recall correctly it can't be the latest (~22) but has to at least be ~12. Might require settling on a common node version manager (nvm?) for scripting purposes.
@seve
Copy link
Member

seve commented Dec 8, 2021

I think we just need a .node_version file in the frontend root folder!

@maniarathi maniarathi added the P1 Priority 1 - Improvement with wide impact, fix within 1 week label Dec 13, 2021
@seve seve linked a pull request Jan 24, 2022 that will close this issue
feat: create .nvmrc #1875
Closed
@atolopko-czi atolopko-czi added P3 Priority 3 - Do we need P3? tech Tech issues that do not require product prioritization. Tech debt, tooling, ops, etc. and removed P1 Priority 1 - Improvement with wide impact, fix within 1 week labels Dec 8, 2022
@metakuni metakuni added the frontend Frontend work label Jan 21, 2023
@metakuni
Copy link
Contributor

metakuni commented Feb 6, 2023

@danieljhegeman / @seve : Is this >1 year old issue still relevant?

@dsadgat
Copy link
Contributor

dsadgat commented Jul 7, 2023

@seve please either update or close, thanks!

@seve seve closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seve seve

Labels
frontend Frontend work P3 Priority 3 - Do we need P3? tech Tech issues that do not require product prioritization. Tech debt, tooling, ops, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: create .nvmrc chanzuckerberg/single-cell-data-portal
6 participants
@maniarathi @seve @danieljhegeman @metakuni @atolopko-czi @dsadgat