Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test on Theano<=1.0.3 and NumPy>=1.16.0 #6001

Merged
merged 6 commits into from Jan 16, 2019
Merged

Skip test on Theano<=1.0.3 and NumPy>=1.16.0 #6001

merged 6 commits into from Jan 16, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Jan 15, 2019

Fixes #5997.

@niboshi niboshi added the cat:test Test or CI related. label Jan 15, 2019
@okuta okuta self-assigned this Jan 15, 2019
niboshi
niboshi commented Jan 15, 2019
View reviewed changes
chainer/links/theano/theano_function.py

.. testcode::
# See chainer/chainer#5997
:skipif: os.environ.get('READTHEDOCS') != 'True' \
Copy link
Member Author

@niboshi niboshi Jan 15, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the readthedocs build, this skipif should never be effective, because that would cause the code to disappear from the documentation.

@niboshi
Copy link
Member Author

niboshi commented Jan 15, 2019

What causes this error? 🤔

reading sources... [ 77%] reference/generated/chainer.links.TheanoFunction      
Exception occurred:
  File "<string>", line 4, in <module>
ImportError: No module named 'cupy'
The full traceback has been saved in /tmp/sphinx-err-z7al7qfb.log, if you want to report the issue to the developers.

toslunar
toslunar requested changes Jan 15, 2019
View reviewed changes
chainer/links/theano/theano_function.py Outdated Show resolved Hide resolved
chainer/links/theano/theano_function.py Outdated Show resolved Hide resolved
tests/chainer_tests/links_tests/theano_tests/test_theano_function.py Outdated Show resolved Hide resolved
@niboshi niboshi changed the title Skip test on Theano<=1.0.2 and NumPy>=1.16.0 Skip test on Theano<=1.0.3 and NumPy>=1.16.0 Jan 15, 2019
@asmeurer asmeurer mentioned this pull request Jan 15, 2019
Closed
@toslunar
Copy link
Member

Jenkins, test this please.

@toslunar
Copy link
Member

To avoid sphinx-doc/sphinx#5492, could you upgrade Sphinx or Python?

=== Step: docs 
+step_docs
+make -C /Users/travis/build/chainer/chainer/docs html
sphinx-build -b html -d build/doctrees  -W source build/html
Running Sphinx v1.8.0
/Users/travis/.pyenv/versions/3.5.1/lib/python3.5/site-packages/chainer/_environment_check.py:40: UserWarning: Accelerate has been detected as a NumPy backend library.
vecLib, which is a part of Accelerate, is known not to work correctly with Chainer.
We recommend using other BLAS libraries such as OpenBLAS.
For details of the issue, please see
https://docs.chainer.org/en/stable/tips.html#mnist-example-does-not-converge-in-cpu-mode-on-mac-os-x.
Please be aware that Mac OS X is not an officially supported OS.
  ''')  # NOQA
Extension error:
Could not import extension sphinx.transforms.post_transforms.compat (exception: cannot import name 'TYPE_CHECKING')
make: *** [html] Error 2
The command "bash scripts/ci/travis/run-tests.sh script" exited with 2.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2d37aef, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@toslunar @niboshi
testcode -> doctest
6786d1a 
Co-Authored-By: niboshi <niboshi000@gmail.com>
toslunar
toslunar reviewed Jan 16, 2019
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer updating Sphinx to removing Python 3.5.1 from CI.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
toslunar and others added 2 commits January 16, 2019 14:09
@toslunar @niboshi
Require sphinx==1.8.2
1b10eba 
Co-Authored-By: niboshi <niboshi000@gmail.com>
@toslunar @niboshi
Require sphinx==1.8.2
a598024 
Co-Authored-By: niboshi <niboshi000@gmail.com>
@niboshi
Copy link
Member Author

niboshi commented Jan 16, 2019

Fixed as suggested.

@niboshi niboshi requested a review from toslunar January 16, 2019 05:09
@toslunar
Copy link
Member

Jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit a598024, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@toslunar
Copy link
Member

I found test_asscalar in tests/chainerx_tests/unit_tests/routines_tests/test_manipulation.py is still failing in Jenkins test, which seems unrelated to the PR.

@toslunar toslunar added this to the v6.0.0b2 milestone Jan 16, 2019
@toslunar toslunar self-assigned this Jan 16, 2019
@toslunar toslunar merged commit 0861d4a into chainer:master Jan 16, 2019
@niboshi niboshi deleted the fix-theano-numpy-incompat branch January 16, 2019 06:49
@niboshi niboshi mentioned this pull request Jan 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okuta okuta okuta left review comments

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

@okuta okuta

Labels
cat:test Test or CI related.
Projects
None yet
Milestone
v6.0.0b2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@niboshi @toslunar @chainer-ci @okuta