Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctest to run in single-GPU environment #6029

Merged
merged 1 commit into from
Jan 19, 2019

Conversation

niboshi
Copy link
Member

@niboshi niboshi commented Jan 18, 2019

Currently doctest can't be run on a single-GPU environment.
As we have increased the required sphinx version in #6001, we can use :skipif: option now.

I think testing.is_requires_satisfied() can be removed in favor of doctest_helper.skipif_requires_satisfied(). It has not been released yet.

@niboshi niboshi added the cat:test Test or CI related. label Jan 18, 2019
@niboshi niboshi force-pushed the doctest-single-gpu-environment branch from d6a8d18 to 3940e42 Compare January 18, 2019 07:49
@niboshi niboshi force-pushed the doctest-single-gpu-environment branch from 3940e42 to de455cb Compare January 18, 2019 09:23
@okuta okuta self-assigned this Jan 19, 2019
@okuta okuta added this to the v6.0.0b2 milestone Jan 19, 2019
@okuta
Copy link
Member

okuta commented Jan 19, 2019

jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit de455cb, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

@okuta
Copy link
Member

okuta commented Jan 19, 2019

LGTM!

@okuta okuta merged commit 930e278 into chainer:master Jan 19, 2019
@niboshi niboshi deleted the doctest-single-gpu-environment branch January 19, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants