#537: Fix and add accessible names, improve tooltip accessibility and add keywords filter tooltip texts #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-morris-cessda
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ended up making more changes to tooltips to improve their accessibility since just adding label to them would have not really made them any better for users using screen readers. This meant making changes to the new keywords filter also so I noticed that it didn't have its own texts in translations/en.json yet so I added them at the same time (do they look okay?).
No simple way to add accessible names to elements from searchkit: SearchBox (main search box), InputFilter (Keywords filter) and RangeFilter/RangeSliderInput (Collection years filter). They don't support adding aria-label (or aria-labelledby) or id. Everything else now has accessible name in one way or another (mostly with aria-label).