Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephadm: pin flake8 to 5.0.4 #49040

Merged
merged 3 commits into from
Nov 24, 2022
Merged

cephadm: pin flake8 to 5.0.4 #49040

merged 3 commits into from
Nov 24, 2022

Commits on Nov 24, 2022

  1. cephadm: pin flake8 to 5.0.4 

    to workaround zheller/flake8-quotes#110
flake8 v5.0.4 is the last known-to-work flake8 before flake8 v6.0.0.

Fixes: https://tracker.ceph.com/issues/58069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
    @tchaikov
    tchaikov committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ecb3fb1 View commit details
    Browse the repository at this point in the history

  2. qa/tasks/cephfs: annotate variable without comment 

    to silence the warning like
```
flake8 run-test: commands[0] | flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/test_full.py:6:5: F401 'typing.Optional' imported but unused
```

since we've migrated to python3.6 and up, there is no need to be
compatible with Python 2 anymore.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
    @tchaikov
    tchaikov committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    2413da8 View commit details
    Browse the repository at this point in the history

  3. pybind/mgr: use annotation style without comment 

    * use annotation style without comment
* add noqa to import statement to prevent flake8 from complaining
  those which import typing modules

to silence the warnings like:

```
flake8 run-test: commands[0] | flake8 --config=tox.ini alerts balancer cephadm cli_api crash devicehealth diskprediction_local hello iostat localpool nfs orchestrator prometheus selftest
cephadm/schedule.py:5:1: F401 'typing.Callable' imported but unused
cephadm/schedule.py:8:1: F401 'ceph.deployment.service_spec.ServiceSpec' imported but unused
cephadm/tests/fixtures.py:17:1: F401 'orchestrator.OrchResult' imported but unused
orchestrator/module.py:4:1: F401 'typing.Set' imported but unused
orchestrator/module.py:17:1: F401 'ceph.deployment.inventory.Device' imported but unused
prometheus/module.py:17:1: F401 'typing.DefaultDict' imported but unused
6     F401 'typing.Callable' imported but unused
ERROR: InvocationError for command /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/.tox/flake8/bin/flake8 --config=tox.ini alerts
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
    @tchaikov
    tchaikov committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    7894e7b View commit details
    Browse the repository at this point in the history