fix: Assembly not found on Windows #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/windows
branch
from
233a0db
to
2a8a0bd
Compare
mrgrain
force-pushed
the
mrgrain/fix/windows
branch
from
d0f4512
to
742dfc4
Compare
mrgrain
force-pushed
the
mrgrain/fix/windows
branch
from
f892d8e
to
5c2416d
Compare
mrgrain
force-pushed
the
mrgrain/fix/windows
branch
2 times, most recently
from
f59ad90
to
c5b1210
Compare
mrgrain
commented
Apr 29, 2024
| @@ -38,7 +38,7 @@ export class Npm { | |||
| // code execution as part of the install command using npm hooks. (e.g postInstall) | |||
| '--ignore-scripts', | |||
| // save time by not running audit | |||
| '--no-autit', | |||
| '--no-audit', | |||
mrgrain
force-pushed
the
mrgrain/fix/windows
branch
from
c5b1210
to
6b18444
Compare
rix0rrr
approved these changes
Apr 29, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsii-docgen fails in Windows with the error
Assembly "<assembly-name>" not found.The reason for this is that the path passed to the glob library we use must only use forward slashes.
However on Windows when using jsii-docgen, it may contain backslashes.
To fix the issue, we pass the assemblies directory as CWD to glob instead. The CWD doesn't have the same limitation in regards to backslashes.
Other fixes involve making the npm helpers Windows aware.
And finally this PR adds a Windows test to the compat build matrix.