Skip to content

Commit

Permalink
fix: use version of glob that works on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
mrgrain committed Apr 28, 2024
1 parent 28d3f16 commit 233a0db
Show file tree
Hide file tree
Showing 7 changed files with 64 additions and 48 deletions.
1 change: 1 addition & 0 deletions .npmignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ const project = new CdklabsTypeScriptProject({
'@jsii/spec',
'case',
'fs-extra',
'glob-promise',
'glob',
'glob@10.1.0', // yarn can't handle the jackspeak dependency introduced in newer versions, see https://github.com/isaacs/node-glob/issues/542
'jsii-reflect',
'semver',
'yargs',
Expand Down
3 changes: 1 addition & 2 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/docgen/view/documentation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as os from 'os';
import * as path from 'path';
import { loadAssemblyFromFile, SPEC_FILE_NAME } from '@jsii/spec';
import * as fs from 'fs-extra';
import * as glob from 'glob-promise';
import { glob } from 'glob';
import * as reflect from 'jsii-reflect';
import { TargetLanguage, transliterateAssembly, UnknownSnippetMode } from 'jsii-rosetta';
import { Npm } from './_npm';
Expand Down Expand Up @@ -407,7 +407,7 @@ export class Documentation {
});

const ts = new reflect.TypeSystem();
for (let dotJsii of await glob.promise(`${this.assembliesDir}/**/${SPEC_FILE_NAME}`)) {
for (let dotJsii of await glob(`${this.assembliesDir}/**/${SPEC_FILE_NAME}`)) {
// we only transliterate the top level assembly and not the entire type-system.
// note that the only reason to translate dependant assemblies is to show code examples
// for expanded python arguments - which we don't to right now anyway.
Expand Down
92 changes: 56 additions & 36 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 233a0db

Please sign in to comment.