Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for default interface members in inheritance-based proxy types #661

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add support for default interface members in inheritance-based proxy types #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
dd250a6
`DefaultInterfaceMembersTestCase`: use strings
stakx Aug 31, 2023
5e7cfc4
Add more tests for default interface method impls
stakx Aug 31, 2023
501be75
Fix proceeding to default impls in interface proxies
stakx Aug 31, 2023
65475c5
Polish & optimize the code changes just made
stakx Aug 31, 2023
ce4be78
Fix interception of inherited default impls in class proxies
stakx May 21, 2022
9e7a15e
Reduce impact of extra collection pass
stakx Aug 31, 2023
c542f13
Add more tests for default interface property impls
stakx Aug 31, 2023
840748a
Fix tests for properties with default impls
stakx Aug 31, 2023
a7b6a7c
Add more tests re: methods with default impls
stakx Sep 1, 2023
0bb493c
Add test for generic method with default impl
stakx Sep 1, 2023
fe40634
Add tests for static interface methods
stakx Sep 1, 2023
27828bd
Add tests for method default impls in additional interfaces
stakx Sep 1, 2023
09d4c15
Group tests using `#region`s
stakx Sep 1, 2023
982f5ff
Add tests for protected methods with default impls
stakx Sep 1, 2023
e41315c
Exclude non-overridable methods from collection
stakx Sep 1, 2023
ae9139f
Add tests for method default impls in mixins
stakx Sep 1, 2023
51112db
Update changelog
stakx Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
Enhancements:
- Two new generic method overloads `proxyGenerator.CreateClassProxy<TClass>([options], constructorArguments, interceptors)` (@backstromjoel, #636)
- Allow specifying which attributes should always be copied to proxy class by adding attribute type to `AttributesToAlwaysReplicate`. Previously only non-inherited, with `Inherited=false`, attributes were copied. (@shoaibshakeel381, #633)
- Support for C# 8+ [default interface methods](https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-8.0/default-interface-methods) in interface and class proxies without target (@stakx, #661)

Bugfixes:
- `ArgumentException`: "Could not find method overriding method" with overridden class method having generic by-ref parameter (@stakx, #657)
Expand Down
2 changes: 1 addition & 1 deletion buildscripts/common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<LangVersion>9.0</LangVersion>
<LangVersion>11.0</LangVersion>
<NoWarn>$(NoWarn);CS1591;CS3014;CS3003;CS3001;CS3021</NoWarn>
<NoWarn>$(NoWarn);CS0612;CS0618</NoWarn> <!-- TODO: Remove this line once `[Obsolete]` members have been dealt with. -->
<RepositoryType>git</RepositoryType>
Expand Down