Add support for default interface members in inheritance-based proxy types #661
Commits on Sep 10, 2023
-
DefaultInterfaceMembersTestCase: use strings... instead of `MethodBase`s to identify which methods get invoked. This should make tests easier to read & understand.
-
Add more tests for default interface method impls
Two of these tests are failing: * Class proxies cannot intercept interface methods with a default implementation if the proxied class type does not override it. * Interface proxies cannot proceed to default implementations.
-
-
-
Fix interception of inherited default impls in class proxies
A class implementing an interface with default method implementations will not necessarily override those methods; in such cases, the methods are currently "invisible" to DynamicProxy and thus won't get proxied. This can be solved by an extra pass over all interfaces to collect such methods, as is done in this commit. Ideally we wouldn't have to iterate over all interfaces more than once, so we should next make an effort to limit the runtime impact of this extra pass.
-
Reduce impact of extra collection pass
Assuming that default interface methods are relatively rare, if we keep track of which interfaces contain any of them at all, we can then limit our extra pass during class proxy generation to just those interfaces and exclude the rest (i.e. hopefully the majority). Additionally, our collector may skip some of the more expensive checks by bailing out for methods it isn't actually interested in.
-
-
Fix tests for properties with default impls
... by properly forwarding the "standalone" flag in the newly added collector.
-
Add more tests re: methods with default impls
Those essentially target "mixed" scenarios where default implementations show up next to "regular" methods. This is to better ensure that the new code paths will not interfere with pre-existing logic.
-
Add test for generic method with default impl
The code changes we made do not suggest that pre-existing logic dealing with generics might somehow no longer work, however we did add a bit of new code for generics which we should target with at least one test.
-
Add tests for static interface methods
This includes a test for `static abstract` methods that remains ignored for now, since we haven't implemented support for this C# 11 language feature, nor do we target any runtimes that support it. (The test is being added as a future reminder, once we start targeting .NET 7+.)
-
-
-
Add tests for protected methods with default impls
A few of these tests fail due to `Debug.Assert` failures in `Interface- MembersWithDefaultImplementationCollector`.
-
Exclude non-overridable methods from collection
`sealed` methods do not show up in interface mappings, so make sure `InterfaceMembersWithDefaultImplementationCollector` can deal with them anyway in case of interfaces that contain both `sealed` methods as well as overridable ones with a default implementation.
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.