Upgrade to Rails 6

[christiannelson]

The first beta is out: https://edgeguides.rubyonrails.org/6_0_release_notes.html

We typically upgrade raygun-rails sometime during the beta period, once we have a sense of the stability of Rails.

Upgrading includes updating the rails gems and massaging any configuration to best match what would be in a new Rails 6 app. Thanks to @mattbrictson, I learned about railsdiff.org, which made finding other differences much easier. Maybe of which have been resolved in this PR.

Tasks

• Upgrade Rails and related gems
• Adopt new configuration options and structure
• Explore defaulting to parallel testing (or make it very easy to do so): NOTE - Not supported by rspec, for either thread or process based parallelization.

Notes

• Dropped sass-rails because it's deprecated, use sassc-rails only. rails g scaffold didn't raise an exception, so something has been fixed.
• Did not choose to go all in on webpacker, even though it's the default in rails 6. I want to see what other people think about it and check it out myself first.

[mattbrictson]

I wonder if it would be convenient to fold the upgrade to bootstrap 4.2.1 (#137) into this PR? I think the bootstrap upgrade would benefit from some more thorough testing that would naturally be part of doing the Rails 6 migration.

[christiannelson]

Sounds great to me. I’ll do it.

On Tue, Jan 29, 2019 at 5:58 PM Matt Brictson ***@***.***> wrote: I wonder if it would be convenient to fold the upgrade to bootstrap 4.2.1 ( #137 <#137>) in this PR? I think the bootstrap upgrade would benefit from some more thorough testing that would naturally be part of doing the Rails 6 migration. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#150 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJh601-w7gvFqkSGvk_8SeNxS8fFTjgks5vIPxggaJpZM4aTw20> .

-- Christian Nelson | Carbon Five | christian@carbonfive.com

[mattbrictson]

I think the setup/update scripts needs some updates because the FileUtils module is no longer included.

$ bin/setup 
== Installing dependencies ==
The Gemfile's dependencies are satisfied

== Copying sample files ==
Traceback (most recent call last):
	3: from bin/setup:11:in `<main>'
	2: from /Users/mbrictson/.rbenv/versions/2.6.3/lib/ruby/2.6.0/fileutils.rb:128:in `cd'
	1: from /Users/mbrictson/.rbenv/versions/2.6.3/lib/ruby/2.6.0/fileutils.rb:128:in `chdir'
bin/setup:22:in `block in <main>': undefined method `cp' for main:Object (NoMethodError)

[christiannelson]

Did some research about using RSpec with the new built-in parallel testing in Rails 6. It's not good news, sadly: rspec/rspec-rails#2104

The issue is that rspec-core is not threadsafe and making it threadsafe is non trivial and not a priority.

Rails 6 supports both multi-process and multi-thread parallelization. So maybe there's a way to still support multi-process parallelization with RSpec and Rails 6? Will look into that a little more.

[seport]

lgtm, but maybe someone else should also take a 👀 at it too

[mattbrictson]

I'm looking at the railsdiff – http://railsdiff.org/5.2.3/6.0.0.rc1 – and it seems that Rails 6 makes these changes to bin:

• bin/bundle has been removed
• bin/setup and bin/update have been consolidated into one idempotent bin/setup script

Should we mirror those changes here?

[christiannelson]

@mattbrictson I didn't know about railsdiff. I will look for other differences between the versions too.

[mattbrictson]

I think the other big difference is that Rails 6 drops JS from the asset pipeline in favor of webpacker. I am not sure we want to go that far. However if we continue with application.js etc. then we are diverging somewhat from "standard" Rails.

[mattbrictson-babylon]

Looks good! 👍

[mattbrictson]

I approve as well 😄