Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump bootstrap from 4.1.3 to 4.3.1 #159

Merged
merged 1 commit into from
Feb 23, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 15, 2019

Bumps bootstrap from 4.1.3 to 4.3.1.

Release notes

Sourced from bootstrap's releases.

v4.2.1

  • Bootstrap rubygem now depends on SassC instead of Sass.
Changelog

Sourced from bootstrap's changelog.

Changelog

The changelog is tracked here but also in the Releases section of the GitHub project.
The changelog only includes changes specific to the RubyGem.

The Bootstrap framework changes can be found in the Releases section of twbs/bootstrap.
Release announcement posts on the official Bootstrap blog contain summaries of the most noteworthy changes made in each release of Bootstrap.

4.2.1

  • Bootstrap rubygem now depends on SassC instead of Sass.

4.0.0.beta2.1

Fixes an extraneous sourceMappingURL in bootstrap.js.
#124

4.0.0.beta2

Compass is no longer supported. Minimum required Sass version is now v3.5.2.
#122

4.0.0.alpha3.1

This release corresponds to the upstream Bootstrap 4 Alpha 3.

Commits
  • cbbed2d Bump bootstrap to 4.3.1
  • a63d04c rake update[v4.3.1]
  • abf9232 Updater: Exclude tools/sanitizer.js from bootstrap_js_files
  • 0a29879 Bump to v4.3.0
  • c406232 rake update[v4.3.0]
  • 2f54168 Bump to v4.2.1
  • e8dde96 rake update[v4.2.1]
  • 4192f90 rake update[v4-dev]
  • 804e3dd Depend on sassc-rails, specify required_ruby_version
  • 2277fb3 Set min precision to 6 as per upstream
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Feb 15, 2019
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/bootstrap-4.3.1 branch from f80f0e7 to 49401ce Compare February 17, 2019 18:10
@dependabot-preview
Copy link
Contributor Author

We've just been alerted that this update fixes a security vulnerability:

Sourced from The GitHub Security Advisory Database.

Moderate severity vulnerability that affects bootstrap and bootstrap-sass
In Bootstrap 4 before 4.3.1 and Bootstrap 3 before 3.4.1, XSS is possible in the tooltip or popover data-template attribute. For more information, see: https://blog.getbootstrap.com/2019/02/13/bootstrap-4-3-1-and-3-4-1/

Affected versions: ["< 4.3.1"]

@dependabot-preview dependabot-preview bot changed the title Bump bootstrap from 4.1.3 to 4.3.1 [Security] Bump bootstrap from 4.1.3 to 4.3.1 Feb 22, 2019
@mattbrictson
Copy link
Contributor

@marclove we had been holding off on upgrading bootstrap until Rails 6 (see #150) because bootstrap 4.3.1 also forces us to switch to sassc. But I think we should pull the trigger now given this is now a security issue. I will do a quick smoke test before merging.

@mattbrictson
Copy link
Contributor

Generated a scaffold and the bootstrap styling looks fine and I didn't encounter and errors or warnings. LGTM 🚀

@mattbrictson mattbrictson merged commit 8f85e23 into master Feb 23, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/bootstrap-4.3.1 branch February 23, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants