Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to codebase #1995

Merged
merged 28 commits into from
Aug 3, 2021
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
937871c
starting adding types to codebase
MasterOdin Jun 17, 2021
3cfd71a
more typing
MasterOdin Jun 17, 2021
88bc125
replace rest of types
MasterOdin Jun 19, 2021
761495d
fix types in tests
MasterOdin Jun 19, 2021
0baf356
fix type hint on Config class
MasterOdin Jun 19, 2021
6ef2a2c
replace mixed with concrete types
MasterOdin Jun 19, 2021
df0901f
fix typehint on NullGenerator
MasterOdin Jun 19, 2021
f8d4391
return ConfigInterface not Config
MasterOdin Jun 19, 2021
f385bbb
fix tests
MasterOdin Jun 19, 2021
f8f1aad
fix phpstan errors
MasterOdin Jun 19, 2021
1296fee
getValues can be null
MasterOdin Jun 19, 2021
a3e86e7
more things can be null
MasterOdin Jun 19, 2021
cfb4f9f
more nulls
MasterOdin Jun 19, 2021
2e4b1e8
fix accidental test failures
MasterOdin Jun 19, 2021
223d553
more nulls
MasterOdin Jun 19, 2021
166b310
convert int to float for Column::
MasterOdin Jun 19, 2021
0dd2a06
fix int/float typing
MasterOdin Jun 20, 2021
5978259
remove typing on RawBufferedOutput
MasterOdin Jun 20, 2021
5dbfd1e
parseDefault may receive null
MasterOdin Jun 20, 2021
32d7368
Update src/Phinx/Db/Adapter/AdapterFactory.php
MasterOdin Jul 28, 2021
8d608dd
Apply suggestions from code review
MasterOdin Jul 28, 2021
be536ff
more review comment addressing
MasterOdin Jul 28, 2021
1d638fe
add inline type hint for phpstan
MasterOdin Jul 28, 2021
f7d6a2f
review comment
MasterOdin Jul 28, 2021
2c9a111
Merge branch '0.next' into add_typing
MasterOdin Aug 3, 2021
d15e3da
Update phpstan-baseline.neon
MasterOdin Aug 3, 2021
468c283
Fix limit type hint back to int
MasterOdin Aug 3, 2021
5222f12
missed a test
MasterOdin Aug 3, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Phinx/Console/Command/Create.php
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
}

// Get the alternative template and static class options from the command line, but only allow one of them.
/** @var string|null */
MasterOdin marked this conversation as resolved.
Show resolved Hide resolved
$altTemplate = $input->getOption('template');
/** @var string|null */
$creationClassName = $input->getOption('class');
if ($altTemplate && $creationClassName) {
throw new InvalidArgumentException('Cannot use --template and --class at the same time');
Expand Down