Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to codebase #1995

Merged
merged 28 commits into from
Aug 3, 2021
Merged

Add type hints to codebase #1995

merged 28 commits into from
Aug 3, 2021

Commits on Jun 17, 2021

  1. starting adding types to codebase

    @MasterOdin
    MasterOdin committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    937871c View commit details
    Browse the repository at this point in the history

  2. more typing

    @MasterOdin
    MasterOdin committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    3cfd71a View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. replace rest of types

    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    88bc125 View commit details
    Browse the repository at this point in the history

  2. fix types in tests 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    761495d View commit details
    Browse the repository at this point in the history

  3. fix type hint on Config class 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    0baf356 View commit details
    Browse the repository at this point in the history

  4. replace mixed with concrete types 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    6ef2a2c View commit details
    Browse the repository at this point in the history

  5. fix typehint on NullGenerator 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    df0901f View commit details
    Browse the repository at this point in the history

  6. return ConfigInterface not Config 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    f8d4391 View commit details
    Browse the repository at this point in the history

  7. fix tests 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    1 Configuration menu
    Copy the full SHA
    f385bbb View commit details
    Browse the repository at this point in the history

  8. fix phpstan errors 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    f8f1aad View commit details
    Browse the repository at this point in the history

  9. getValues can be null 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    1296fee View commit details
    Browse the repository at this point in the history

  10. more things can be null 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    a3e86e7 View commit details
    Browse the repository at this point in the history

  11. more nulls 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    cfb4f9f View commit details
    Browse the repository at this point in the history

  12. fix accidental test failures 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    2e4b1e8 View commit details
    Browse the repository at this point in the history

  13. more nulls 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    223d553 View commit details
    Browse the repository at this point in the history

  14. convert int to float for Column:: 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    166b310 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. fix int/float typing 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    0dd2a06 View commit details
    Browse the repository at this point in the history

  2. remove typing on RawBufferedOutput 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    5978259 View commit details
    Browse the repository at this point in the history

  3. parseDefault may receive null 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    5dbfd1e View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Update src/Phinx/Db/Adapter/AdapterFactory.php 

    Co-authored-by: othercorey <corey.taylor.fl@gmail.com>
    @MasterOdin @othercorey
    MasterOdin and othercorey committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    32d7368 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: othercorey <corey.taylor.fl@gmail.com>
    @MasterOdin @othercorey
    MasterOdin and othercorey committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8d608dd View commit details
    Browse the repository at this point in the history

  3. more review comment addressing 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    be536ff View commit details
    Browse the repository at this point in the history

  4. add inline type hint for phpstan

    @MasterOdin
    MasterOdin committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    1d638fe View commit details
    Browse the repository at this point in the history

  5. review comment

    @MasterOdin
    MasterOdin committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    f7d6a2f View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. Merge branch '0.next' into add_typing

    @MasterOdin
    MasterOdin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    2c9a111 View commit details
    Browse the repository at this point in the history

  2. Update phpstan-baseline.neon

    @MasterOdin
    MasterOdin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    d15e3da View commit details
    Browse the repository at this point in the history

  3. Fix limit type hint back to int

    @MasterOdin
    MasterOdin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    468c283 View commit details
    Browse the repository at this point in the history

  4. missed a test 

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    @MasterOdin
    MasterOdin committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    5222f12 View commit details
    Browse the repository at this point in the history