GH-2852: Use the default background color when writing to the Console #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoproiete
commented
Dec 12, 2020
augustoproiete
force-pushed
the
use-default-background-color-of-console-when-ansi
branch
from
e633b72
to
8eb5e5e
Compare
augustoproiete
force-pushed
the
use-default-background-color-of-console-when-ansi
branch
from
8eb5e5e
to
7425a86
Compare
augustoproiete
force-pushed
the
use-default-background-color-of-console-when-ansi
branch
from
7425a86
to
24b891d
Compare
augustoproiete
force-pushed
the
use-default-background-color-of-console-when-ansi
branch
from
24b891d
to
e7c3f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix to remove the black background color when writing messages to the console, and use the default background color instead.
It seems to work well for any dark background. For white backgrounds (e.g. TeamCity) it will require a different color palette as some messages are written using white foreground color.
/cc @patriksvensson as per chat via e-mail