Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default background color of console when ansi #3094

Conversation

augustoproiete
Copy link
Member

Re-opening #2984 which got closed with the deletion of the release/1.0.0 branch

Quick fix to remove the black background color when writing messages to the console, and use the default background color instead.

It seems to work well for any dark background. For white backgrounds (e.g. TeamCity) it will require a different color palette as some messages are written using white foreground color.


@devlead devlead force-pushed the use-default-background-color-of-console-when-ansi branch from c92ed08 to 3c60c60 Compare February 13, 2021 17:33
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit bfb0cb4 into cake-build:develop Feb 13, 2021
@devlead
Copy link
Member

devlead commented Feb 13, 2021

@augustoproiete your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal output colours
2 participants