Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal output colours #2852

Closed
gitfool opened this issue Sep 9, 2020 · 4 comments · Fixed by #3094
Closed

Terminal output colours #2852

gitfool opened this issue Sep 9, 2020 · 4 comments · Fixed by #3094
Assignees
@patriksvensson
Labels
Bug
Projects
1.x Next
Milestone
v1.1.0

Comments

@gitfool
Copy link
Contributor

gitfool commented Sep 9, 2020

I'm using Windows Terminal with PowerShell 7, which normally has a black background, but I've configured it to use the now classic blue background:

image

The text with black background looks a little jarring. Are the terminal output colours looking as expected / intended?
@patriksvensson
Copy link
Member

@gitfool I've also noticed this. Will take a look at it.

@gitfool
Copy link
Contributor Author

gitfool commented Oct 20, 2020

@pascalberger could this issue be added to the v1.0.0 milestone?

@pascalberger pascalberger added this to the v1.1.0 milestone Oct 20, 2020
@pascalberger
Copy link
Member

@gitfool We currently only add issues which are blocking the release in 1.0.0 since we really want to get it out. I would not classify this not as blocking. If we get a PR in time we can add, but otherwise probably in a 1.0.0 bugfix release. I added it therefore to the 1.1.0 milestone.

@pascalberger pascalberger mentioned this issue Dec 8, 2020
Open
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Dec 12, 2020
@augustoproiete
(cake-buildGH-2852) Use the default background color when writing to …
d4ee164 
…the Console
@augustoproiete augustoproiete mentioned this issue Dec 12, 2020
Closed
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Dec 13, 2020
@augustoproiete
(cake-buildGH-2852) Move ConsoleColorEx to Constants
e633b72
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Dec 13, 2020
@augustoproiete
(cake-buildGH-2852) Move ConsoleColorEx to Constants
8eb5e5e
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Dec 22, 2020
@augustoproiete
(cake-buildGH-2852) Use the default background color when writing to …
88721d0 
…the Console
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Dec 22, 2020
@augustoproiete
(cake-buildGH-2852) Move ConsoleColorEx to Constants
7425a86
@pascalberger pascalberger added this to To do in 1.x Next via automation Dec 28, 2020
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Jan 4, 2021
@augustoproiete
(cake-buildGH-2852) Use the default background color when writing to …
f787529 
…the Console
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Jan 4, 2021
@augustoproiete
(cake-buildGH-2852) Move ConsoleColorEx to Constants
24b891d
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Jan 24, 2021
@augustoproiete
(cake-buildGH-2852) Use the default background color when writing to …
c57e2c7 
…the Console
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Jan 24, 2021
@augustoproiete
(cake-buildGH-2852) Move ConsoleColorEx to Constants
e7c3f4d
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Feb 7, 2021
@augustoproiete
(cake-buildGH-2852) Use the default background color when writing to …
c7f1ee1 
…the Console
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Feb 7, 2021
@augustoproiete
(cake-buildGH-2852) Move ConsoleColorEx to Constants
c92ed08
@augustoproiete augustoproiete mentioned this issue Feb 7, 2021
Merged
devlead pushed a commit to augustoproiete-forks/cake-build--cake that referenced this issue Feb 13, 2021
@augustoproiete @devlead
(cake-buildGH-2852) Use the default background color when writing to …
192e8d0 
…the Console
devlead pushed a commit to augustoproiete-forks/cake-build--cake that referenced this issue Feb 13, 2021
@augustoproiete @devlead
(cake-buildGH-2852) Move ConsoleColorEx to Constants
3c60c60
@devlead devlead modified the milestones: v1.x Next, v1.1.0 Feb 13, 2021
1.x Next automation moved this from To do to Done Feb 13, 2021
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.1.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patriksvensson patriksvensson

Labels
Bug
Projects
1.x Next
Done
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Use default background color of console when ansi augustoproiete-forks/cake-build--cake
5 participants
@patriksvensson @gitfool @devlead @pascalberger @cake-build-bot