Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always call checkDNSPropagation in DNS01Solver #179

Merged
merged 1 commit into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. Always call checkDNSPropagation in DNS01Solver

    Calling checkAuthoritativeNss is wrong as it's not inter-changeable with
    checkDNSPropagation.
    
    Though IIUC it's not necessary to follow CNAME when in Wait(), with or
    without OverrideDomain, let's wait until the override domain gets some
    usage to change this. The reason that following CNAME is not necessary
    is that CNAME cannot co-exist with other DNS records, if we succeed in
    setting a TXT record on that domain, it cannot have a CNAME record.
    
    @IndeedNotJames
    crccw committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    4b2a9e5 View commit details
    Browse the repository at this point in the history