Always call checkDNSPropagation in DNS01Solver #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling checkAuthoritativeNss is wrong as it's not inter-changeable with checkDNSPropagation. Though IIUC it's not necessary to follow CNAME when in Wait(), with or without OverrideDomain, let's wait until the override domain gets some usage to change this. The reason that following CNAME is not necessary is that CNAME cannot co-exist with other DNS records, if we succeed in setting a TXT record on that domain, it cannot have a CNAME record. @IndeedNotJames
mholt
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling checkAuthoritativeNss is wrong as it's not inter-changeable with
checkDNSPropagation. See #160 (comment)
Though IIUC it's not necessary to follow CNAME when in Wait(), with or
without OverrideDomain, let's wait until the override domain gets some
usage to change this. The reason that following CNAME is not necessary
is that CNAME cannot co-exist with other DNS records, if we succeed in
setting a TXT record on that domain, it cannot have a CNAME record.
@IndeedNotJames