Skip to content

Commit

Permalink
Comments on dependencies, removed unnecessary clone
Browse files Browse the repository at this point in the history
  • Loading branch information
Psykopear committed Sep 23, 2022
1 parent 3434e3e commit de7ffb3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@ futures = { version = "0.3.21" }
log = { version = "0.4" }
# TODO: PyO3 pinned to current latest main commit, which includes pyo3->chrono integration
# Change to version "0.17.2" as soon as it is released
# pyo3 = { version = "0.17.2", features = ["macros", "chrono"] }
pyo3 = { git = "https://github.com/pyo3/pyo3", rev = "86ce4d1a1", version = "0.17", features = ["macros", "chrono"] }
# TODO: pyo3-log too is pinned to a fork, so that it compiles together with the unreleased PyO3 version.
# Change this to the version "0.7" as soon as PyO3 "0.17.2" itself is released.
# The current pyo3-log version should work as it is, since it depends on pyo3 "~0.17".
# pyo3-log = "0.7"
pyo3-log = { git = "https://github.com/psykopear/pyo3-log", rev = "802b6f4", version = "0.7" }
scopeguard = { version = "1.1.0" }
send_wrapper = { version = "0.6.0" }
Expand All @@ -39,6 +41,9 @@ rdkafka = { version = "0.28.0", features = [ "cmake-build", "gssapi-vendored", "
rdkafka = { version = "0.28.0", features = [ "cmake-build", "gssapi", "ssl" ] }

[dev-dependencies]
# TODO: PyO3 pinned to current latest main commit, which includes pyo3->chrono integration
# Change to version "0.17.2" as soon as it is released
# pyo3 = { version = "0.17.2", default-features = false, features = ["macros", "chrono"] }
pyo3 = { git = "https://github.com/pyo3/pyo3", rev = "86ce4d1a1", version = "0.17", default-features = false, features = ["macros", "chrono"] }

[features]
Expand Down
2 changes: 1 addition & 1 deletion src/window/testing_clock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ impl<V> Clock<V> for TestingClock {
Poll::Ready(None) => DateTime::<Utc>::MAX_UTC,
_ => Python::with_gil(|py| {
let py_clock = self.py_clock.borrow(py);
py_clock.now.clone()
py_clock.now
}),
}
}
Expand Down

0 comments on commit de7ffb3

Please sign in to comment.