Skip to content

Commit

Permalink
Temporarily pin unreleased PyO3 and pyo3-log
Browse files Browse the repository at this point in the history
  • Loading branch information
Psykopear committed Sep 23, 2022
1 parent 0c565c5 commit 3434e3e
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 10 deletions.
29 changes: 23 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@ bincode = { version = "1.3.3" }
chrono = { version = "0.4", features = [ "serde" ] }
futures = { version = "0.3.21" }
log = { version = "0.4" }
pyo3 = { git = "https://github.com/psykopear/pyo3", branch = "chrono", version = "0.17", features = ["macros", "chrono"] }
# pyo3-log = { version = "0.7" }
# TODO: PyO3 pinned to current latest main commit, which includes pyo3->chrono integration
# Change to version "0.17.2" as soon as it is released
pyo3 = { git = "https://github.com/pyo3/pyo3", rev = "86ce4d1a1", version = "0.17", features = ["macros", "chrono"] }
# TODO: pyo3-log too is pinned to a fork, so that it compiles together with the unreleased PyO3 version.
# Change this to the version "0.7" as soon as PyO3 "0.17.2" itself is released.
# The current pyo3-log version should work as it is, since it depends on pyo3 "~0.17".
pyo3-log = { git = "https://github.com/psykopear/pyo3-log", rev = "802b6f4", version = "0.7" }
scopeguard = { version = "1.1.0" }
send_wrapper = { version = "0.6.0" }
serde = { version = "1.0.134" }
Expand All @@ -34,7 +39,7 @@ rdkafka = { version = "0.28.0", features = [ "cmake-build", "gssapi-vendored", "
rdkafka = { version = "0.28.0", features = [ "cmake-build", "gssapi", "ssl" ] }

[dev-dependencies]
pyo3 = { git = "https://github.com/psykopear/pyo3", branch = "chrono", version = "0.17", default-features = false, features = ["macros", "chrono"] }
pyo3 = { git = "https://github.com/pyo3/pyo3", rev = "86ce4d1a1", version = "0.17", default-features = false, features = ["macros", "chrono"] }

[features]
extension-module = ["pyo3/extension-module"]
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ fn sleep_release_gil(py: Python, secs: u64) {
#[pymodule]
#[pyo3(name = "bytewax")]
fn mod_bytewax(py: Python, m: &PyModule) -> PyResult<()> {
// pyo3_log::init();
pyo3_log::init();

dataflow::register(py, m)?;
execution::register(py, m)?;
Expand Down

0 comments on commit 3434e3e

Please sign in to comment.