Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winch(arm64): fpu arithmetics (add, sub, mul, div, min, max) and regalloc #8365

Merged
merged 8 commits into from Apr 15, 2024
Merged

winch(arm64): fpu arithmetics (add, sub, mul, div, min, max) and regalloc #8365

merged 8 commits into from Apr 15, 2024

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Apr 14, 2024 •
edited

This is a draft with a handful of tests for float_add{32,64} (LGTM but another pair of eyes would help), I will add the remaining later. Added the remaining tests.

@evacchi
winch(arm64): fpu arithmetics (add, sub, mul, div, min, max)
d1a64c3 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi
disas: add fpu test cases (add)
7f01bb4 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi
winch(arm64): regalloc for fpu
ea2a6b7 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi
disas: add fpu test cases (add64)
c909fdf 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@github-actions github-actions bot added the winch Winch issues or pull requests label Apr 14, 2024
@github-actions GitHub Actions
Copy link

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@evacchi
disas: add fpu test cases
71276a3 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
saulecabrera
saulecabrera reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; the general direction looks good to me. I left a couple of comments that I think need to be resolved before landing this work.

winch/codegen/src/isa/aarch64/regs.rs Outdated Show resolved Hide resolved
winch/codegen/src/isa/aarch64/regs.rs Outdated Show resolved Hide resolved
winch/codegen/src/isa/aarch64/masm.rs Show resolved Hide resolved
evacchi and others added 3 commits April 15, 2024 18:30
@evacchi @saulecabrera
Apply suggestions from code review
81058c5 
Co-authored-by: Saúl Cabrera <saulecabrera@gmail.com>
@evacchi @saulecabrera
Apply suggestions from code review
28801c4 
Co-authored-by: Saúl Cabrera <saulecabrera@gmail.com>
@evacchi
add todo for f32 mov
6b5f346 
Signed-off-by: Edoardo Vacchi <evacchi@users.noreply.github.com>
@evacchi evacchi marked this pull request as ready for review April 15, 2024 16:32
@evacchi evacchi requested review from a team as code owners April 15, 2024 16:32
@evacchi evacchi requested review from fitzgen and removed request for a team April 15, 2024 16:32
@saulecabrera saulecabrera added this pull request to the merge queue Apr 15, 2024
Merged via the queue into bytecodealliance:main with commit d36d470 Apr 15, 2024
21 checks passed
@evacchi evacchi deleted the winch-fpu branch April 15, 2024 20:13
saulecabrera added a commit to saulecabrera/wasmtime that referenced this pull request Apr 24, 2024
@saulecabrera
winch: Use single precision fmov
38ce9c8 
This commit is a follow-up to bytecodealliance#8365. In bytecodealliance#8453 single precision fmov was introduced in Cranelift, so now we can make use that instruction in Winch.
@saulecabrera saulecabrera mentioned this pull request Apr 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 24, 2024
@saulecabrera
winch(aarch64): Use single precision fmov (#8460)
a54d34f 
* winch: Use single precision fmov

This commit is a follow-up to #8365. In #8453 single precision fmov was introduced in Cranelift, so now we can make use that instruction in Winch.

* Remove stale `TODO` comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

Assignees
No one assigned
Labels
winch Winch issues or pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evacchi @saulecabrera