Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the Index annotation for KSP to annotations. #4919

Merged
merged 1 commit into from Oct 6, 2022
Merged

Move the Index annotation for KSP to annotations. #4919

merged 1 commit into from Oct 6, 2022

Commits on Oct 6, 2022

  1. Move the Index annotation for KSP to annotations. 

    The processor will produce a Index annotated class for each LibraryGlideModule in given compilation unit. If the Index annotation is in the ksp module, it will not be accessible in parent modules, causing a compilation failure. To work around that, we'll follow the same pattern as we did for Java and place the annotation in the annotations package, but with package private visibility.

Any compilation unit that uses our annotation processor must already
have a dependency on annotation, so the Index annotation will be
available.

Fixes bumptech#4911.
    @sjudd
    sjudd committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    463688b View commit details
    Browse the repository at this point in the history