Move the Index annotation for KSP to annotations. #4919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjudd
added
import-ready
sjudd
force-pushed
the
fix_library_glide_module_deps
branch
from
f29af5c
to
e59817f
Compare
The processor will produce a Index annotated class for each LibraryGlideModule in given compilation unit. If the Index annotation is in the ksp module, it will not be accessible in parent modules, causing a compilation failure. To work around that, we'll follow the same pattern as we did for Java and place the annotation in the annotations package, but with package private visibility. Any compilation unit that uses our annotation processor must already have a dependency on annotation, so the Index annotation will be available. Fixes bumptech#4911.
sjudd
force-pushed
the
fix_library_glide_module_deps
branch
from
e59817f
to
463688b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The processor will produce a Index annotated class for each LibraryGlideModule in given compilation unit. If the Index annotation is in the ksp module, it will not be accessible in parent modules, causing a compilation failure. To work around that, we'll follow the same pattern as we did for Java and place the annotation in the annotations package, but with package private visibility.
Any compilation unit that uses our annotation processor must already have a dependency on annotation, so the Index annotation will be available.
While I've added a test that at least verifies Indexes are generated correctly, unfortunately it doesn't detect the issue with imports. It's still useful to add here because it helps validate that the changes I made actually work.
Fixes #4911.