Fix documentation and validation on `UpdateModulesRequest.default_lab…

…el_name` (#108) If present, it must be non-empty and may not point to an archived label.
bufbuild · May 8, 2024 · e92b877 · e92b877
1 parent 1ad2f24
commit e92b877
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/buf/registry/module/v1/module_service.proto b/buf/registry/module/v1/module_service.proto
@@ -168,8 +168,11 @@ message UpdateModulesRequest {
     //
     // This Label may not yet exist.
     //
-    // This may point to an archived Label.
-    optional string default_label_name = 7 [(buf.validate.field).string.max_len = 250];
+    // This may not point to an archived Label.
+    optional string default_label_name = 7 [
+      (buf.validate.field).string.min_len = 1,
+      (buf.validate.field).string.max_len = 250
+    ];
   }
   // The Modules to update.
   repeated Value values = 1 [

diff --git a/buf/registry/module/v1beta1/module_service.proto b/buf/registry/module/v1beta1/module_service.proto
@@ -168,8 +168,11 @@ message UpdateModulesRequest {
     //
     // This Label may not yet exist.
     //
-    // This may point to an archived Label.
-    optional string default_label_name = 7 [(buf.validate.field).string.max_len = 250];
+    // This may not point to an archived Label.
+    optional string default_label_name = 7 [
+      (buf.validate.field).string.min_len = 1,
+      (buf.validate.field).string.max_len = 250
+    ];
   }
   // The Modules to update.
   repeated Value values = 1 [