Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCN-464 Support GoReleaser on tag creation #677

Merged
merged 4 commits into from Oct 17, 2022

Conversation

elliotmjackson
Copy link
Contributor

PR extends Github actions to include GoReleaser this will allow users to pull binaries directly from the release.

Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>

Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
@elliotmjackson elliotmjackson changed the title Support GoReleaser on tag creation TCN-464 Support GoReleaser on tag creation Oct 17, 2022
@elliotmjackson elliotmjackson marked this pull request as ready for review October 17, 2022 14:03
@elliotmjackson elliotmjackson enabled auto-merge (squash) October 17, 2022 14:03
@elliotmjackson elliotmjackson merged commit b24bbba into bufbuild:main Oct 17, 2022
Copy link
Member

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please at least address the Go version comment before merging!

- uses: actions/setup-go@v3
with:
go-version: 1.19.1
cache: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we at least use 1.19.x so we get the latest patch? This is already out of date.

footer: |
## Thanks!

Those were the changes on {{ .Tag }}!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the release notes template from connect-go? Github supports generating release notes automatically now, and they do a nice job highlighting new contributors.

(Fine to leave this config, or replace it with a message that these notes are temporary and should be replaced with GH's autogen.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants