Improve Java UUID Validation Performance #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the existing UUID validation implementation with the UUID implementation that was added to Java in version 15. This implementation is significantly faster than our previous implementation, and requires fewer allocations (in fact only one global allocation, which is lazy and cached from there on out). Only SIMD vector instructions could be used to make it even faster.
|
|
buildbreaker
previously approved these changes
Oct 14, 2022
|
The build failure is unrelated to the patch. |
elliotmjackson
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the existing UUID validation implementation with the UUID implementation that was added to Java in version 15. This implementation is significantly faster than our previous implementation, and requires fewer allocations (in fact only one global allocation, which is lazy and cached from there on out). Only SIMD vector instructions could be used to make it even faster.