Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change maven groupID #662

Merged
merged 9 commits into from Oct 3, 2022
Merged

Change maven groupID #662

merged 9 commits into from Oct 3, 2022

Conversation

elliotmjackson
Copy link
Contributor

@elliotmjackson elliotmjackson commented Sep 30, 2022

Prerequisite: #661

Now that a new version, with relocation tags, has been sent to io/envoyproxy - we can complete our first release under build.buf.protoc-gen-validate

Signed-off-by: Elliot Jackson 13633636+ElliotMJackson@users.noreply.github.com

Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
@elliotmjackson elliotmjackson changed the title Change groupID Change maven groupID Sep 30, 2022
joshcarp
joshcarp previously approved these changes Oct 3, 2022
Copy link

@joshcarp joshcarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	java/pgv-artifacts/pom.xml
#	java/pgv-java-grpc/pom.xml
#	java/pgv-java-stub/pom.xml
#	java/pgv-java-validation/pom.xml
#	java/pgv-test-coverage-report/pom.xml
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
Signed-off-by: Elliot Jackson <13633636+ElliotMJackson@users.noreply.github.com>
@elliotmjackson elliotmjackson marked this pull request as ready for review October 3, 2022 19:34
@elliotmjackson elliotmjackson enabled auto-merge (squash) October 3, 2022 19:35
@@ -12,8 +12,8 @@ jobs:
build:
runs-on: ubuntu-latest
env:
SONATYPE_USER: ${{secrets.SONATYPE_USER}}
SONATYPE_PASSWORD: ${{secrets.SONATYPE_PASSWORD}}
SONATYPE_USER: ${{secrets.BUF_SONATYPE_USER}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just use these directly?

@elliotmjackson elliotmjackson merged commit 78941c7 into main Oct 3, 2022
@elliotmjackson elliotmjackson deleted the ejackson/complete-relocation branch October 5, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants