Simplify handling of custom features in buf breaking #2967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, never mind. This broke tests in a serious way, so it clearly isn't working. I'll revisit/re-open once I get it all working... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the logic for querying the
(pb.cpp)and(pb.java)custom features ("custom" because they are extension fields inFeatureSetinstead of regular fields).The gist is that, with some improved handling over in protocompile for custom features and potentially mismatching descriptors, we can get rid of a bunch of special logic in here. (Yay!)
This is just a draft PR right now because it's pointing to a commit in protocompile that hasn't yet merged to main (here: bufbuild/protocompile#306). When that PR is merged, I'll update the
go.modpin and mark this as ready for review.