Add Cargo Registry support to buf.plugin.yaml
#2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plan is to land this on `main` (for the plugins repo) and then merge it over to `dev`.
mfridman
reviewed
May 8, 2024
| // version_requirement specifies the version requirement of the dependency. | ||
| string version_requirement = 2; | ||
| // default_features specifies whether or not default features will be enabled for the dependency. | ||
| bool default_features = 3; |
There was a problem hiding this comment.
Can you remind me, what happens if this is true and we also specify features, it's additive? Or can you only set custom features if default is false.
There was a problem hiding this comment.
Had to check on this myself — best reference is https://doc.rust-lang.org/cargo/reference/features.html#the-default-feature. My understanding is that it's additive — default-features = true, features = ['xyz'] results in both the 'xyz' and any features in the default feature to be enabled.
There was a problem hiding this comment.
Got it, really doesn't matter for our purposes since it'll be a property of the plugin itself.
mfridman
approved these changes
May 8, 2024
mfridman
approved these changes
May 8, 2024
This was referenced May 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan is to land this on
main(for the plugins repo) and then merge it over todev. Draft until I PR over on plugins.