Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "label" check with "cardinality" check #2927

Merged
merged 8 commits into from
May 2, 2024
Merged

Replace "label" check with "cardinality" check #2927

merged 8 commits into from
May 2, 2024

Commits on Apr 29, 2024

  1. replace FIELD_SAME_LABEL with FIELD_SAME_CARDINALITY; introduce wire-… 

    … and wire-json-compatible variants for v2
    @jhump
    jhump committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bc036af View commit details
    Browse the repository at this point in the history

  2. update oneof checks to ignore synthetic oneofs; these are now handled… 

    … by cardinality check
    @jhump
    jhump committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2710aa3 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. add back test for FIELD_SAME_LABEL, to verify its config swaps in the… 

    … new rule correctly
    @jhump
    jhump committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6b0d59d View commit details
    Browse the repository at this point in the history

  2. change v1 to match v2: different levels of cardinality check based on… 

    … category
    @jhump
    jhump committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ecd898b View commit details
    Browse the repository at this point in the history

  3. update test expectations: if 'use' FIELD_SAME_LABEL directly, it can … 

    …report errors in triplicate
    @jhump
    jhump committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8199ab3 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. oops, missed a test

    @jhump
    jhump committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0b89281 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into jh/new-buf-breaking-check

    @jhump
    jhump committed May 1, 2024
    Configuration menu
    Copy the full SHA
    48dcbac View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. don't report errors in triplicate if FIELD_SAME_LABEL not explicitly … 

    …used
    @jhump
    jhump committed May 2, 2024
    Configuration menu
    Copy the full SHA
    abc325c View commit details
    Browse the repository at this point in the history