Make "buf lint" work correctly with top-level extensions #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
commented
Apr 26, 2024
private/bufpkg/bufcheck/buflint/internal/buflintcheck/buflintcheck.go
Outdated
Show resolved
Hide resolved
…herit' message-wide ignores for the two field-specific rules
bufdev
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR, I tried to fix "buf lint" so it would work with top-level extensions (here). However, I only fixed the potential panic in one of the field rules and failed to address a similar issue in another field linter rule.
So this fixes the other rule and adds tests for both rules that cover extensions -- both nested extensions inside messages as well as top-level extensions.