Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where bufmodulebuild.ModuleBucketBuilder.BuildForBucket did not properly accept an empty configuration #2411

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Fix issue where bufmodulebuild.ModuleBucketBuilder.BuildForBucket did not properly accept an empty configuration #2411

merged 1 commit into from
Sep 2, 2023

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Sep 2, 2023

See comment for explanation.

oliversun9
oliversun9 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@oliversun9 oliversun9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bufdev bufdev merged commit cd01222 into main Sep 2, 2023
8 checks passed
@bufdev bufdev deleted the bufmodulebuild-bug branch September 2, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliversun9 oliversun9 oliversun9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bufdev @oliversun9