TCN-875 Various bugs in release action #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+49
to
+52
| commit-message: "Update version to v${{env.VERSION}}" | ||
| branch: release/v${{env.VERSION}} | ||
| delete-branch: true | ||
| title: "Release ${{env.VERSION}}" | ||
| body: Release prepared for ${{env.VERSION}} | ||
| title: "Release v${{env.VERSION}}" |
There was a problem hiding this comment.
won't these vs be doubled? (I realize this looks a lot like https://github.com/bufbuild/buf/blob/main/.github/workflows/release.yaml so maybe not?)
There was a problem hiding this comment.
these will not, the input should be x.y.z without any v, even though that is not enforced at this stage 😂
| private_key: ${{ secrets.TOKEN_EXCHANGE_GH_APP_PRIVATE_KEY }} | ||
| repository: ${{ github.repository }} | ||
| permissions: >- | ||
| {"contents": "write"} |
There was a problem hiding this comment.
does this need "pull_requests": "write" permission, similar to buf's release workflow?
There was a problem hiding this comment.
this one does not, the one you reference is OP
stefanvanburen
approved these changes
Dec 12, 2022
elliotmjackson
deleted the
ejackson/tcn-875-various-bugs-in-buf-setup-action-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vin pr outputv1branch never completedall resolved.