Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcjson: add addresstype arg to getnewaddress #1776

Merged
merged 3 commits into from Apr 9, 2022
Merged

btcjson: add addresstype arg to getnewaddress #1776

merged 3 commits into from Apr 9, 2022

Conversation

chappjc
Copy link
Contributor

@chappjc chappjc commented Dec 3, 2021 •
edited

This adds a AddressType field to the btcjson.GetNewAddressCmd type to facilitate requesting different address types from btcwallet.
Required for btcsuite/btcwallet#783
Partially resolves #1703

@chappjc chappjc mentioned this pull request Dec 3, 2021
Closed
@coveralls
Copy link

coveralls commented Dec 3, 2021 •
edited

Pull Request Test Coverage Report for Build 2024889801

  • 6 of 14 (42.86%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.0002%) to 54.186%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/wallet.go 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.07%
rpcclient/wallet.go 2 0%
Totals Coverage Status
Change from base Build 2006933401: -0.0002%
Covered Lines: 24767
Relevant Lines: 45707
💛 - Coveralls

This was referenced Dec 5, 2021
Merged
Closed
jcvernaleo
jcvernaleo approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit d14f18d into btcsuite:master Apr 9, 2022
@chappjc chappjc deleted the segwit-rpc branch April 13, 2022 12:53
@chappjc chappjc mentioned this pull request Jun 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change command getnewaddress
3 participants
@chappjc @coveralls @jcvernaleo