Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to btcd v0.23.0 and neutrino v0.14.2 #804

Closed
wants to merge 1 commit into from
Closed

build: update to btcd v0.23.0 and neutrino v0.14.2 #804

wants to merge 1 commit into from

Conversation

Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Jun 2, 2022

No description provided.

chappjc
chappjc reviewed Jun 2, 2022
View reviewed changes
cmd/sweepaccount/main.go
@@ -196,7 +196,9 @@ func makeDestinationScriptSource(rpcClient *rpcclient.Client, accountName string
// GetNewAddress always returns a P2PKH address since it assumes
// BIP-0044.
newChangeScript := func() ([]byte, error) {
destinationAddress, err := rpcClient.GetNewAddress(accountName)
destinationAddress, err := rpcClient.GetNewAddress(
accountName, "legacy",
Copy link
Contributor

@chappjc chappjc Jun 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #783
It was intended to be merged with btcsuite/btcd#1776 but that slipped by.
That really has to be merged now that 0.23 is tagged with an rpcclient package that sends the address type arg.

Probably too late for btcsuite/btcd#1844 unless you wanna do a 0.23.1 already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, realized I had overlooked that as soon as I had to add this to fix the compilation issue. I spotted another thing we need to patch on the btcd side as well re a missing return statement.

Copy link
Contributor

@chappjc chappjc Jun 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, OK that's good then. In that case please consider either btcsuite/btcd#1844 itself or the alternative diff in the comment btcsuite/btcd#1844 (comment) (which causes the address type to be omitted from the marshalled request if the provided type string is "")... or any other change you'd prefer! :) Feel free to close any of those and do things differently. I just didn't want to leave rpcclient unusable for the current wallet.

@Roasbeef
Copy link
Member Author

Roasbeef commented Jun 2, 2022

New failures for the pruned block dispatcher:

--- FAIL: TestPrunedBlockDispatcherQuerySameBlock (5.00s)
    pruned_block_dispatcher_test.go:446: expected peer to be dialed
--- FAIL: TestPrunedBlockDispatcherPeerPoller (9.00s)
    pruned_block_dispatcher_test.go:561: expected a peer to be queried
    pruned_block_dispatcher_test.go:189: 
        	Error Trace:	pruned_block_dispatcher_test.go:189
        	            				panic.go:482
        	            				testing.go:864
        	            				testing.go:948
        	            				pruned_block_dispatcher_test.go:359
        	            				pruned_block_dispatcher_test.go:561
        	Error:      	Should be empty, but was map[6deac7df6473bb535d415137dcddbc8bd4b7ce52c16c8113bd9652e4cd770953:1]
        	Test:       	TestPrunedBlockDispatcherPeerPoller
--- FAIL: TestPrunedBlockDispatcherMultipleQueryPeers (5.00s)
    pruned_block_dispatcher_test.go:514: expected peer to be dialed
--- FAIL: TestPrunedBlockDispatcherMultipleGetData (5.00s)
    pruned_block_dispatcher_test.go:490: expected a peer to be queried
    pruned_block_dispatcher_test.go:189: 
        	Error Trace:	pruned_block_dispatcher_test.go:189
        	            				panic.go:482
        	            				testing.go:864
        	            				testing.go:948
        	            				pruned_block_dispatcher_test.go:359
        	            				pruned_block_dispatcher_test.go:490
        	Error:      	Should be empty, but was map[54fc87e07ef3002286c6c09dd7ddd4fff1a6ceea56e767356631075ac397d100:1 18c0a611f32038482708a957f578c9c7c6c12ae7979ec5d6113e4f69538da718:1 19adf4e6ed7778887b2f0b61ebfb2f000a9ab051be1fe1cba857281e7f72d119:1 1b5ee[24](https://github.com/btcsuite/btcwallet/runs/6716525615?check_suite_focus=true#step:6:25)687c92b1fbd7481028f2027e4c0643b5e8bb8a08ad2919473e9fa1327:1 6b98ffe10320420fabb4bdbe530557a785631a92454339cbf0f5777e4b3c5328:1 3427a6bf1d10d6b45511ce90572222e1ee46f97722cfb8[25](https://github.com/btcsuite/btcwallet/runs/6716525615?check_suite_focus=true#step:6:26)909fa7a82cd36a2a:1 61b4fb2fcc85dc3b014d79e1fdbf1bf9cb9b045f69c2c2702a6e33d6f96a1930:1 42b65e037ff0f3028a7d9395f53a9ec87f58b3d9768be103c077a5a4a3ed2530:1 6a9d3bc9bf4f[26](https://github.com/btcsuite/btcwallet/runs/6716525615?check_suite_focus=true#step:6:27)a6624a19d9ff1ce4fb1f64ce59a00ec6a0da3d3fbc88294c33:1 75dab55c5007ac9b1000eb33410ea80e2211419399f5284647acea1ec22ff535:1 11debc31943302cd2ef85e15948f1761844b56a8d71b7e84db3564[27](https://github.com/btcsuite/btcwallet/runs/6716525615?check_suite_focus=true#step:6:28)d7d56f38:1 4be4e25888907d52dcd174138a644b362bdea9a63e05cb772d7e609df2bfe351:1 6deac7df6473bb535d415137dcddbc8bd4b7ce52c16c8113bd9652e4cd770953:1 6cd6eaafba9fd58e3ab51532701dea3016988b60a7bd46361b4ee92080d29957:1 39b3026b09ea568481e5dadf96310ddd692eb5890e46e9186997040dfb69d858:1 1fbf57f55173d6c45d97d29e2f79910fa6985f20dde4f7ceaa5f72038774636d:1 7e000fb9710845ddb49b36244fa6f544a3a4af7aa18079fec3dc9f99ab40f385:1 567e59bff94f0cdcb4bd26bd717db3f7b0d92eafc8daf6286fbbef8b65146186:1 5e9174b210a12dc5956f47c8b28a97898f583bc8b62ed4ab51f12faa6e4a0fa0:1 2e3da6a19d7edc866d957fb755f626b2bbd170c0ac77564203b8b4fc5308eda7:1 7839d1b197313c580c81c12a2e7ecfcd6c7b3c4dc885a05f2eeed25c0a3904ad:1 73dc875b871f68e01fca97021595d7bc170c6896cd6f9351400c08c5a6376bbb:1 725bc5e1d2218b39ac40590edd85b83012bd1ec83f0c132013d060f1f413d7c8:1 6803760c6387515471ae0b196d83d868f4a97c4dd5e35d8c94598fc3be4a39d4:1 092dac783f5e071eb9bfb2f33d34396cc241f216425c16bc5067937f6b99eee9:1 7344732642ea7407a3ec950a731e35ba925cfc1fb0707535b92d1e70e261faf2:1]
        	Test:       	TestPrunedBlockDispatcherMultipleGetData
--- FAIL: TestPrunedBlockDispatcherInvalidBlock (5.00s)
    pruned_block_dispatcher_test.go:601: expected a peer to be queried
    pruned_block_dispatcher_test.go:189: 
        	Error Trace:	pruned_block_dispatcher_test.go:189
        	            				panic.go:482
        	            				testing.go:864
        	            				testing.go:948
        	            				pruned_block_dispatcher_test.go:359
        	            				pruned_block_dispatcher_test.go:601
        	Error:      	Should be empty, but was map[6deac7df6473bb535d415137dcddbc8bd4b7ce52c16c8113bd9652e4cd770953:1]
        	Test:       	TestPrunedBlockDispatcherInvalidBlock
        	```

This was referenced Jun 2, 2022
Merged
Merged
@Roasbeef
Copy link
Member Author

Roasbeef commented Jun 7, 2022

Replaced by #805

@Roasbeef Roasbeef closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chappjc chappjc chappjc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Roasbeef @chappjc