Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum node.js version from 0.8 to 4 #2071

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

legobeat
Copy link

@legobeat legobeat commented Sep 10, 2023

Motivation: readable-stream@3 breaks compatibility with Node.js versions < 4.

The last version to reach EoL being dropped here is v0.12.x, which ended maintenance 2016-12-31 .

Blocking:

Related:

@legobeat legobeat marked this pull request as ready for review September 10, 2023 01:46
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason to drop anything; if readable-stream v3 doesn’t support the node versions we do, we can simply not upgrade to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants