New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Node.js versions used in Travis CI checks #2008
base: master
Are you sure you want to change the base?
Conversation
Node.js versions below 10.x are not maintained anymore, so it is probably best to use some newer, still maintained versions. For release cyles of Node.js see the official site: <https://nodejs.org/en/about/releases/>.
Node.js versions below 10.x are not maintained anymore, so it is probably best to use some newer, still maintained versions.
AppVeyor cannot find a matching package to install for Node 16, so do not use it on AppVeyor. For an example of that problem see <https://ci.appveyor.com/project/browserify/browserify/builds/39074493/job/f56gjo1d8f1odghj>
It seems that AppVeyor cannot install Node.js 16 yet: https://ci.appveyor.com/project/browserify/browserify/builds/39074493/job/f56gjo1d8f1odghj |
Change requested by @ljharb, so let's do this.
Since there has been no activity here for almost a week: Is there anything else blocking this PR? Any more change requests? If so, please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good. Since this pull request has been approved one and a half month ago but it has not been merged yet: Is there anything else to do? If not, can someone merge it please? |
@striezel tests are failing on master in node < 4, and altho i reviewed this PR, i don't typically maintain browserify, so it needs to wait for the maintainers. |
@goto-bus-stop or who is currently maintaining browserify: Is there a chance to get a review on the changes? Is this still relevant after almost a year now? |
This comment was marked as spam.
This comment was marked as spam.
@ljharb @goto-bus-stop @feross Would dropping 0.10 and 0.12 be up for reconsideration alongside #2070 ? Split that out to #2071, which does not overlap with this PR. |
Nope, we will continue to support them. |
So who is typically maintaining browserify? Should I ping anybody? As for Node < 4, that versions already failed before that pull request:
However, there have been no browserify builds on Travis CI for quite a while, and I suppose it might be time to consider a switch, e. g. to GitHub Actions. So part of this PR may not be relevant anymore, and there possibly should also be CI runs for Node.js 18 and 20, too. |
Node.js versions below 10.x are not maintained anymore, so it is probably best to use some newer, still maintained versions.
For release cyles of Node.js see the official site: https://nodejs.org/en/about/releases/.