Add build step to fetch mime.types from Apache and build types.json #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally getting around to addressing #61. ~~~This also uses
request
to fetch Apache's mime.types file from the source URL, rather than keeping a possibly out-of-date version in this repo, which has caused confusion for people wanting to add new types. (Of course, I'm sure those same people will end up editingtypes.json
, but that's an issue for another day.)~~~Edit: Using mime-db instead, since they handle all the nastiness around aggregating mime resources and community extensions. Makes code a lot simpler. So, really, at this point the only thing node-mime will offer over something like mime-types is that the types.json file it generates is a little more compact, and it allows for project-specific customization via
define()
.