Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build step to fetch mime.types from Apache and build types.json #107

Merged
merged 2 commits into from Feb 5, 2015

Conversation

broofa
Copy link
Owner

@broofa broofa commented Nov 27, 2014

Finally getting around to addressing #61. ~~~This also uses request to fetch Apache's mime.types file from the source URL, rather than keeping a possibly out-of-date version in this repo, which has caused confusion for people wanting to add new types. (Of course, I'm sure those same people will end up editing types.json, but that's an issue for another day.)~~~
Edit: Using mime-db instead, since they handle all the nastiness around aggregating mime resources and community extensions. Makes code a lot simpler. So, really, at this point the only thing node-mime will offer over something like mime-types is that the types.json file it generates is a little more compact, and it allows for project-specific customization via define().

@braddunbar
Copy link

This looks rather nice to me! 👍 I'd love to use mime via browserify.

@broofa
Copy link
Owner Author

broofa commented Feb 4, 2015

Reworked code to use mime-db as canonical source of mime types. (I'll be working with mime-db team to insure node.types extensions are incorporated into mime-db.)

@broofa broofa merged commit f44261e into master Feb 5, 2015
@broofa broofa deleted the build_step branch February 5, 2015 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants