Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on node-mime module #18

Closed
wants to merge 1 commit into from
Closed

Remove dependency on node-mime module #18

wants to merge 1 commit into from

Conversation

broofa
Copy link
Member

@broofa broofa commented Feb 4, 2015

I'm switching node-mime over to mime-db. See broofa/mime#107 . Thus removing the [circular] dependency that will cause between these two modules is a Good Thing. See also @jonathanong's comment to that effect at https://github.com/jshttp/mime-db/blob/master/scripts/build.js#L22

I'm switching node-mime over to mime-db. See broofa/mime#107 .  Thus removing the [circular] dependency that will cause between these two modules is a Good Thing.  See also @jonathanong's comment to that effect at https://github.com/jshttp/mime-db/blob/master/scripts/build.js#L22
@dougwilson
Copy link
Contributor

Neat. What's going to happen to node-mime? Is is going to stay the same, but simply source from here?

@dougwilson
Copy link
Contributor

So, really, at this point the only thing node-mime will offer over something like mime-types is that the types.json file it generates is a little more compact, and it allows for project-specific customization via define().

Ok, sounds good to me :)

@broofa
Copy link
Member Author

broofa commented Feb 4, 2015

What's going to happen to node-mime? Is is going to stay the same, but simply source from here?

Yeah, see referenced pull request. node-mime gets an install script that builds types.json, an only-whats-needed version of mime-db's db.json. This conversion seemed prudent given that the impetus for all this was users' desire for node-mime to work with browserify (i.e. in the browser where download sizes are important)... and types.json comes in at 8KB gzip'ed .vs. db.json's 17KB.

@dougwilson
Copy link
Contributor

I plan to release this tonight so I'm not blocking you :)

@dougwilson dougwilson closed this in 3775109 Feb 5, 2015
dougwilson pushed a commit that referenced this pull request Feb 5, 2015
dougwilson pushed a commit that referenced this pull request Feb 5, 2015
@dougwilson
Copy link
Contributor

Thanks, @broofa , this has been published as 1.6.1. I also added you as a contributor: https://github.com/jshttp/mime-db/blob/v1.6.1/package.json#L8

@jonathanong
Copy link
Member

👍

@broofa
Copy link
Member Author

broofa commented Feb 5, 2015

Just published 1.3.2, which includes the aforementioned PR.

Thanks for the contributor nod!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants