-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on node-mime module #18
Conversation
I'm switching node-mime over to mime-db. See broofa/mime#107 . Thus removing the [circular] dependency that will cause between these two modules is a Good Thing. See also @jonathanong's comment to that effect at https://github.com/jshttp/mime-db/blob/master/scripts/build.js#L22
Neat. What's going to happen to |
Ok, sounds good to me :) |
Yeah, see referenced pull request. node-mime gets an install script that builds |
I plan to release this tonight so I'm not blocking you :) |
Thanks, @broofa , this has been published as 1.6.1. I also added you as a contributor: https://github.com/jshttp/mime-db/blob/v1.6.1/package.json#L8 |
👍 |
Just published 1.3.2, which includes the aforementioned PR. Thanks for the contributor nod! |
I'm switching node-mime over to mime-db. See broofa/mime#107 . Thus removing the [circular] dependency that will cause between these two modules is a Good Thing. See also @jonathanong's comment to that effect at https://github.com/jshttp/mime-db/blob/master/scripts/build.js#L22