Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes final modifier from generated Proxy classes. #2068

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Removes final modifier from generated Proxy classes. #2068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5a64ab
Removes final modifier from generated Proxy classes.
cccs-ian May 10, 2023
3f96515
fix typo
cccs-ian May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/zaxxer/hikari/util/JavassistProxyFactory.java
View file
Open in desktop
Expand Up @@ -108,7 +108,7 @@ private static <T> void generateProxyClass(Class<T> primaryInterface, String sup

var superCt = classPool.getCtClass(superClassName);
var targetCt = classPool.makeClass(newClassName, superCt);
targetCt.setModifiers(Modifier.setPublic(Modifier.FINAL));
targetCt.setModifiers(Modifier.PUBLIC);

System.out.println("Generating " + newClassName);

Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/zaxxer/hikari/pool/TestJavassistCodegen.java
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@ public void testCodegen() throws Exception {

int mod = fauxClassLoader.loadClass("com.zaxxer.hikari.pool.HikariProxyConnection").getModifiers();
Assert.assertTrue("Generated proxy class should be public", Modifier.isPublic(mod));
Assert.assertTrue("Generated proxy class should be final", Modifier.isFinal(mod));
Assert.assertTrue("Generated proxy class should not be final", !Modifier.isFinal(mod));

Class<?> proxyFactoryClass = fauxClassLoader.loadClass("com.zaxxer.hikari.pool.ProxyFactory");

Expand Down