Removes final modifier from generated Proxy classes. #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hoping to start conversation about this PR :) |
Foulest
added a commit
to Foulest/HikariCP
that referenced
this pull request
May 5, 2024
- Pulled changes from brettwooldridge#2189 brettwooldridge#2180 brettwooldridge#2157 brettwooldridge#2149 brettwooldridge#2147 brettwooldridge#2133 brettwooldridge#2068 brettwooldridge#2065 brettwooldridge#2038 brettwooldridge#2035 brettwooldridge#2031 brettwooldridge#2010 (aside from code found in removed test functions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the final modifier from the generated proxy classes, allowing clients code to extend them. This PR relates to some changes made here: #1661 where a small bug was fixed associated with the codegen.
Reasoning
My team has extended the HikariProxyResultSet in older versions of HikariCP, to allow us to package up stuff like warnings into the ResultSet implementation. I would be open to the suggestion that only the HikariProxyResultSet be made non-final, and be willing to change the PR to match if is decided that this is the best course of action.
Thanks for your consideration.