Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore bower.json "version" field in bower version #2142

Closed
wants to merge 4 commits into from
Closed

Ignore bower.json "version" field in bower version #2142

wants to merge 4 commits into from

Commits on Apr 2, 2016

  1. Update bower version tests, refs bower#2139. 

    `bower version` currently takes the version from the "version" field of
bower.json, but the spec says that bower ignores it.

This commit updates the `bower version` tests so that they are
consistent with the spec. Now, the tests are based on the assumption
that `bower version` should only use git tags.
    @hdgarrood
    hdgarrood committed Apr 2, 2016
    Configuration menu
    Copy the full SHA
    c0c2858 View commit details
    Browse the repository at this point in the history

  2. Ignore bower.json version in bower version 

    Fixes bower#2139.

Make `bower version` operate solely on git tags, ignoring the version
field in bower.json (if it exists).
    @hdgarrood
    hdgarrood committed Apr 2, 2016
    Configuration menu
    Copy the full SHA
    3fbca6d View commit details
    Browse the repository at this point in the history

  3. Fix eslint failures

    @hdgarrood
    hdgarrood committed Apr 2, 2016
    Configuration menu
    Copy the full SHA
    49c7fef View commit details
    Browse the repository at this point in the history

  4. Use 'git describe' instead of 'git tag' to get tags

    @hdgarrood
    hdgarrood committed Apr 2, 2016
    Configuration menu
    Copy the full SHA
    f3a924b View commit details
    Browse the repository at this point in the history