Ignore bower.json "version" field in bower version
#2142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
force-pushed
the
fix-version-with-semver
branch
2 times, most recently
from
74eeaee
to
77a84e8
Compare
|
Also, if this change is too drastic, an alternative approach could be to update the spec and un-deprecate the "version" field. I think we should definitely do one of these two things - currently, the spec is not consistent with Bower's behaviour. |
|
Pinging @bower/contributors |
|
I think it's good to merge, but we should use |
`bower version` currently takes the version from the "version" field of bower.json, but the spec says that bower ignores it. This commit updates the `bower version` tests so that they are consistent with the spec. Now, the tests are based on the assumption that `bower version` should only use git tags.
Fixes bower#2139. Make `bower version` operate solely on git tags, ignoring the version field in bower.json (if it exists).
hdgarrood
force-pushed
the
fix-version-with-semver
branch
from
77a84e8
to
49c7fef
Compare
|
Done; how's this? |
|
Close, but it doesn't preserve |
|
Also --help documentation is not updated |
|
Possible PR successor at #2232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2139. See the commits for a description of the changes. I just went ahead and did this, because it was easy.
I was thinking that it might be a good idea to warn if the "version" field exists, too. If you agree, where should that go?
Also, if bower now uses tags for versions, I suppose we should support svn too?