New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: library tests to play multiple sources #1333
Conversation
packages/audioplayers_platform_interface/lib/streams_interface.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for continuously improving our tests!
I like the idea of the local server.
overall LGTM
just one concern about the error stream change, I wonder if we can split that off
d25a1eb
to
d37a8c0
Compare
build
workflow
I can also split the server and workflow stuff from this PR if wanted :) Idk if running the tests twice is needed. We could only run the tests on the PRs and the build when pushing to |
I think both are fine, since when it is running on main after a merge we're not really waiting for it anyways, but I also think we don't check the results of that. :) |
Yeah, doesn't gain any profit from time perspective. More was a concern of free gh action minutes, but as long as we don't get in trouble, we could run these. What about the build tests for the PR? Do you think they are necessary? The tests shouldn't be able to run without building anyways I guess.
I more like the approach of a dependency bot, and "hardcode" the version values, to get rid of unexpected failures. This works for Flutter version or even the GH-Action dependencies. So the tests do only run when an update is available and the developer can decide if want to merge the upgrade. |
I don't think we have that restriction since we're an open source organisation.
Yeah, I guess they aren't necessary.
I think a dependency bot works well for normal dependencies, but not that well for Flutter and Dart versions since it is recommended to support a range that includes all minor bumps too. |
I think for organizations it's 2000 minutes. Ahh sry, you're right. It's free for public repos :)
I'm not quite sure, if I get the proposal right. I think for both variants the developer needs to take action ASAP, also for minor bumps. It's sometimes unfortunate, if you have a PR open and suddenly the code doesn't work anymore on the CI because the versions (Flutter or OS versions) have changed, like happened recently in ubuntu. And one needs to fix the os first in another or even worse, in the current PR, and mix the dependency fixes with the feature. With a bot, for every bump the build should run and the developer immediately sees the failures in the PR of the bot. And the dev can make the fixes in there, where it belongs. That are only my thoughts, I'm also fine with other approaches. We can also discuss this later or in the according PR, as we currently do not implement any of these strategies. Merry Christmas 🎁 |
I also splitted the test server from this PR, see #1354 |
Yeah, I guess there are pros and cons to both solutions, I'm fine with any. Merry christmas! 🎅 |
# Conflicts: # .github/workflows/test.yml # packages/audioplayers/example/lib/tabs/sources.dart
build
workflow…sources # Conflicts: # .github/workflows/build.yml # .github/workflows/pull-request.yml # .github/workflows/test.yml
Description
Checklist
fix:
,feat:
,docs:
,chore:
etc).///
, where necessary.Breaking Change
TODO