Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): customizable workflows #1356

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Dec 24, 2022

Description

  • ability to trigger each job individually via workflow_dispatch
  • categorize reusable workflows / jobs into build and test
  • split trigger into pull-request and release

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1333

* categorize jobs into build and test
* split trigger into pull_request and release
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Dec 24, 2022

For this to work correctly we have to change protection rules to allow merging, when pull_request workflow passed, and not anymore the build workflow.
https://github.com/orgs/community/discussions/26698#discussioncomment-3252954
build and test are reusable now, and can be called by its trigger workflow pull-request or release, which makes more sense in terms of naming.

@luanpotter
Copy link
Member

@Gustl22 done!

Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Dec 24, 2022

Thank you!!

@Gustl22 Gustl22 merged commit 3a3d174 into main Dec 24, 2022
@Gustl22 Gustl22 deleted the gustl22/customizable-workflows branch December 24, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants