Make CI green again #768
Merged
Make CI green again #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version of clap above 4.4.9 require Rust 1.74, which exceeds criterion's MSRV of 1.70.
|
CI failures due to |
|
This PR depends on #767 and vice-versa? Could you merge them such that the CI is green? |
Rust now warns about duplicate imports. `std::iter::IntoIterator` is part of the Rust prelude since Rust 2015. This prevents `criterion-plot` from compiling with recent Rust versions because of `#![deny(warnings)]`.
samueltardieu
changed the title
Done. |
lemmih
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of clap above 4.4.9 require Rust 1.74, which exceeds criterion's MSRV of 1.70, and some entities belong to the Rust profile.