Skip to content

Commit

Permalink
Make CI green again (#768)
Browse files Browse the repository at this point in the history
* Force clap version to 4.4.9 to respect MSRV

Version of clap above 4.4.9 require Rust 1.74, which exceeds
criterion's MSRV of 1.70.

* Do not redundantly import `std::iter::IntoIterator`

Rust now warns about duplicate imports. `std::iter::IntoIterator` is
part of the Rust prelude since Rust 2015. This prevents
`criterion-plot` from compiling with recent Rust versions because of
`#![deny(warnings)]`.
  • Loading branch information
samueltardieu committed Mar 26, 2024
1 parent b913e23 commit 9f1db4a
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Expand Up @@ -28,7 +28,7 @@ serde = "1.0"
serde_json = "1.0"
serde_derive = "1.0"
ciborium = "0.2.0"
clap = { version = "4", default-features = false, features = ["std", "help"] }
clap = { version = "=4.4.9", default-features = false, features = ["std", "help"] }
walkdir = "2.3"
tinytemplate = "1.1"
cast = "0.3"
Expand Down
1 change: 0 additions & 1 deletion plot/src/axis.rs
@@ -1,7 +1,6 @@
//! Coordinate axis

use std::borrow::Cow;
use std::iter::IntoIterator;

use crate::map;
use crate::traits::{Configure, Data, Set};
Expand Down
1 change: 0 additions & 1 deletion plot/src/candlestick.rs
@@ -1,7 +1,6 @@
//! "Candlestick" plots

use std::borrow::Cow;
use std::iter::IntoIterator;

use crate::data::Matrix;
use crate::traits::{self, Data, Set};
Expand Down
1 change: 0 additions & 1 deletion plot/src/curve.rs
@@ -1,7 +1,6 @@
//! Simple "curve" like plots

use std::borrow::Cow;
use std::iter::IntoIterator;

use crate::data::Matrix;
use crate::traits::{self, Data, Set};
Expand Down
1 change: 0 additions & 1 deletion plot/src/errorbar.rs
@@ -1,7 +1,6 @@
//! Error bar plots

use std::borrow::Cow;
use std::iter::IntoIterator;

use crate::data::Matrix;
use crate::traits::{self, Data, Set};
Expand Down
1 change: 0 additions & 1 deletion plot/src/filledcurve.rs
@@ -1,7 +1,6 @@
//! Filled curve plots

use std::borrow::Cow;
use std::iter::IntoIterator;

use crate::data::Matrix;
use crate::traits::{self, Data, Set};
Expand Down

0 comments on commit 9f1db4a

Please sign in to comment.