Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a polling fallback to filesystem watcher #254

Closed
wants to merge 1 commit into from

Commits on Jul 7, 2020

  1. Add a polling fallback to filesystem watcher

    Changes to the latest beta version of macOS broke the mechanism that
    we're using to observe filesystem change events. It's more than just
    filesystem observation that has broken: any attempt to run a
    hot-reloading workflow crashes the Figwheel process with an uncaught
    exception at startup. (Note that build-once still works, since it
    doesn't try to access filesystem events).
    
    The underlying hawk library does have an implementation of a
    less-efficient polling watcher. Figwheel can use this to provide
    hot-reloading even when native events aren't available.
    
    This commit wraps the `hawk.core/watch!` function to catch any exception
    that's thrown, and re-try with the same options *except* that it
    explicitly starts a polling watcher.
    
    See also
    
    - gjoseph/BarbaryWatchService#13
    - java-native-access/jna#1216
    
    Part of bhauman#253.
    rgm committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    db0e84c View commit details
    Browse the repository at this point in the history